Skip to content

Conversation

@haodong404
Copy link
Contributor

Description

There is a route named /test/page, and it doesn't work if pushNamed with /test/page/ (which ends with /). This is not what was expected.

So in this PR:

  1. I modified the way of recovering on the first route search. If it failed for the first time, a / will be removed if it's already at the end, or append a / if it doesn't exist at the end.
  2. Fix tests in modular_router_delegate_test.dart

Checklist

  • The title of my PR starts with a Conventional Commit prefix (fix:, feat:, docs: etc).
  • I have read the Contributor Guide and followed the process outlined for submitting PRs.
  • I have updated/added tests for ALL new/updated/fixed functionality.
  • I have updated/added relevant documentation in docs and added dartdoc comments with ///.
  • I have updated/added relevant examples in examples.

Breaking Change

  • Yes, this is a breaking change.
  • No, this is not a breaking change.

Related Issues

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant